This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMock/$httpBackend): fail if a url is provided but is undefined
#12777
+137
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase but otherwise looks good. |
While the `url` parameter is optional for `$httpBackend.when`, `$httpBackend.expect` and related shortcut methods, it should not have the value of `undefined` if it has been provided. This change ensures that an error is thrown in those cases. Closes angular#8442 Closes angular#8462 Closes angular#10934 Closes angular#12777 BREAKING CHANGE It is no longer valid to explicitly pass `undefined` as the `url` argument to any of the `$httpBackend.when...()` and `$httpBackend.expect...()` methods. While this argument is optional, it must have a defined value if it is provided. Previously passing an explicit `undefined` value was ignored but this lead to invalid tests passing unexpectedly.
petebacondarwin
force-pushed
the
ngMock-httpBackend-assertions
branch
2 times, most recently
from
836cc0a to
7551b89
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
urlparameter is optional for$httpBackend.when,$httpBackend.expectand related shortcut methods, it should not have thevalue of
undefinedif it has been provided.This change ensures that an error is thrown in those cases.
Closes #8442
Closes #8462
Closes #10934
BREAKING CHANGE
It is no longer valid to explicitly pass
undefinedas theurlargumentto any of the
$httpBackend.when...()and$httpBackend.expect...()methods.
While this argument is optional, it must have a defined value if it is
provided.
Previously passing an explicit
undefinedvalue was ignored but thislead to invalid tests passing unexpectedly.