Skip to content
This repository was archived by the owner on May 25, 2019. It is now read-only.

[RFR] Fix Strict DI issues and remove ngAnnotate #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions gruntFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = function (grunt) {
// Default task.
grunt.registerTask('default', ['jshint', 'karma:unit']);
grunt.registerTask('serve', ['connect:continuous', 'karma:continuous', 'watch']);
grunt.registerTask('dist', ['ngAnnotate', 'uglify']);
grunt.registerTask('dist', ['uglify']);

// HACK TO ACCESS TO THE COMPONENT-PUBLISHER
function fakeTargetTask(prefix){
Expand Down Expand Up @@ -112,19 +112,10 @@ module.exports = function (grunt) {
uglify: {
options: {banner: '<%= meta.banner %>'},
build: {
expand: true,
cwd: 'dist',
src: ['*.js'],
ext: '.min.js',
dest: 'dist'
}
},

ngAnnotate: {
main: {
expand: true,
cwd: 'src',
src: ['*.js'],
ext: '.min.js',
dest: 'dist'
}
},
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"grunt-contrib-watch": "~0.6.0",
"grunt-conventional-changelog": "~1.1.0",
"grunt-karma": "~0.9.0",
"grunt-ng-annotate": "0.8.0",
"karma": "~0.12.0",
"karma-chrome-launcher": "~0.1.1",
"karma-coffee-preprocessor": "~0.2.1",
Expand Down
2 changes: 1 addition & 1 deletion src/ui-codemirror.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/
angular.module('ui.codemirror', [])
.constant('uiCodemirrorConfig', {})
.directive('uiCodemirror', uiCodemirrorDirective);
.directive('uiCodemirror', ['$timeout', 'uiCodemirrorConfig', uiCodemirrorDirective]);

/**
* @ngInject
Expand Down