This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(accordion): support events from collapse in accordion #6227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable usage of collapse events of collapsed, collapsing, expanded, and expanding in accordion Closes angular-ui#5776
|
This technically is a breaking change, so I will slot this for 3.0.0 |
|
This needs documentation updates as well. Does this behave well if the attributes are not specified? |
|
Added documentation. When the attribute is not there it behaves fine. |
theurere
force-pushed
the
accordion-events
branch
from
a755943 to
0cb84a7
Compare
- Add documentation for collapse events available for accordion
|
@wesleycho why is this change a breaking change ? So this change is fully compatible. We also need the same callback function to make our ui working correctly. |
lager1
added a commit
to CESNET/eduroam-db
that referenced
this pull request
Jan 3, 2019
patch is based on angular-ui/bootstrap@f4640b4 and angular-ui/bootstrap#6227
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5776