feat: Enhanced withDataService to require callState collection name
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerhahnekamp
requested changes
Mar 19, 2025
|
@rainerhahnekamp Test is there. If anything else is needed just let me know. Thanks for answering. |
|
@rainerhahnekamp Thanks! Just wondering if I need to do anything to have it merged ? |
|
@Clarchik, nope, except reminding me to push the merge button 😅. Thanks for that and also for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing collection name to
withDataServicenow requires providingwithCallStatewith the same collection name, otherwise type error.This is also a small alignment with
withDataServicefor signature without collection name. (if it has no collection name butwithCallStatehas - type error)Hope this PR will be useful.