Skip to content

Conversation

@Aonepathan
Copy link

Style properties have been extracted from every component and been placed in corresponding CSS files within the package.

Please let me know if this needs to be changed or was off the mark with the issue!

Closes #35

@cmckni3 cmckni3 self-requested a review November 1, 2017 00:13
Copy link
Collaborator

@cmckni3 cmckni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selectors should actually be :host like they were previously. I would actually prefer adding a class with a super-table prefix for library CSS.

@cmckni3
Copy link
Collaborator

cmckni3 commented Nov 1, 2017

I appreciate the PR, @Aonepathan. Can you make the changes I have outlined? After that I will merge and update the build process.

@Aonepathan
Copy link
Author

@cmckni3 I've made the requested changes, please let me know if the :host pseudo-class should be included in the component.ts files. I went ahead with your recommendation to update host as the class name instead and inserted in the template as a div

@cmckni3
Copy link
Collaborator

cmckni3 commented Nov 2, 2017

I see some issues with the CSS not being applied to components under SuperTableComponent. I think all of the CSS needs to go into a single file to be bundled into the library and included in applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract CSS out of components

2 participants