Skip to content

Add track by on rows in order to get rid of console error shown when… #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add track by on rows in order to get rid of console error shown when… #23

wants to merge 1 commit into from

Conversation

gabistiufliuc
Copy link

… there are duplicates in ng-repeater

@andyperlitch
Copy link
Owner

The reason this is failing is because during the compile function of the apMesaRows directive, the ng-repeat-start attribute value is being updated with the appropriate track by clause. I am unsure why row.$$$index is undefined since it should always be set (here in updateVisibleRows and here in updateVisibleRowsAsync). The reasons why it does not get set on some rows is the real source of this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabistiufliuc @andyperlitch @gabrielstiufliuc