Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bigendian support #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

octo47
Copy link

@octo47 octo47 commented Oct 12, 2016

currently ints and floats encoded in little endian.
in some cases it is preferred to have bigendian (for example for encoding keys for leveldb like databases).

here is a small patch that adds flag to generate bigendian encoding.

@andyleap
Copy link
Owner

I can see the usefulness of this, but my issue is that it makes it an all or nothing thing. Either the whole schema is bigendian, or none of it is. I'd rather add additional types for bigendian, or some kind of modifier similar to the "framed" modifier for structs, so that it can be enabled on a "as needed" basis

@octo47
Copy link
Author

octo47 commented Oct 27, 2016

yeah, sounds good.
will take a look on how that can be done.

thanks.

@sylvainr
Copy link

FYI I ported @octo47's BigEndian support PR to be more easily accessible at https://github.com/sylvainr/gencode-bigendian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants