do-not-review-wip-kumann-pblsamples #764

kumann-dev · 2026-01-08T07:10:32Z

No description provided.

snippet-bot · 2026-01-08T07:10:38Z

Here is the summary of changes.

You are about to add 10 region tags.

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:61, tag android_playbilling_initialize_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:80, tag android_playbilling_enableautoreconnect_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:92, tag android_playbilling_startconnection_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:115, tag android_playbilling_queryproductdetails_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:143, tag android_playbilling_consumeproduct_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:159, tag android_playbilling_acknowledge_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:175, tag android_playbilling_getbillingconfig_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:196, tag android_playbilling_subscription_replace_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:222, tag android_playbilling_subscription_update_deprecated_java
playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java:252, tag android_playbilling_inappmessaging_java

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gemini-code-assist · 2026-01-08T07:10:57Z

Summary of Changes

Hello @kumann-dev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Android application module, playbilling, designed to serve as a practical example for integrating and using the Google Play Billing Library. The module includes a robust BillingClientWrapper class that encapsulates common billing operations, providing a clear reference for developers. It also sets up the necessary Gradle configurations and Android resources for a functional billing sample application.

Highlights

New Play Billing Sample Module: A new Android application module named playbilling has been added to the project, intended to provide samples for the Google Play Billing Library.
Google Play Billing Library Integration: The playbilling module integrates version 8.3.0 of the Google Play Billing Library, along with AndroidX Compose Runtime 1.10.0, and other essential Android dependencies.
Comprehensive BillingClientWrapper: A BillingClientWrapper.java class is introduced, demonstrating various functionalities of the Play Billing Library, including client initialization, product detail queries, purchase management (consume/acknowledge), subscription updates, and in-app messaging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new playbilling module, which serves as a sample for integrating the Google Play Billing Library. The changes include adding necessary dependencies, setting up the module's Gradle build file, and providing a BillingClientWrapper class to encapsulate billing logic.

My review focuses on several key areas:

Application Configuration: The new module is set up as an application but lacks a launchable activity in its manifest, which is a critical issue. The application ID also uses the com.example namespace, which should be avoided.
Code Quality and Best Practices: I've pointed out a potential memory leak related to context handling in BillingClientWrapper, a redundant cast, and several files missing a final newline character.
Security: There are hardcoded placeholder tokens in the billing wrapper, which represents a critical security vulnerability if translated to production code.

Overall, the PR provides a good starting point for a billing sample, but the identified issues, especially the critical ones, should be addressed to ensure the application is correctly configured, robust, and secure.

gemini-code-assist · 2026-01-08T07:12:55Z

playbilling/src/main/AndroidManifest.xml

+    <application
+        android:allowBackup="true"
+        android:icon="@mipmap/ic_launcher"
+        android:label="@string/app_name"
+        android:roundIcon="@mipmap/ic_launcher_round"
+        android:supportsRtl="true"
+        android:theme="@style/Theme.Snippets" />


This module is configured as an application via plugins { alias(libs.plugins.android.application) } in build.gradle, but there's no launchable Activity declared in the AndroidManifest.xml. An application module requires at least one Activity with an intent filter for android.intent.action.MAIN and android.intent.category.LAUNCHER to be installed and launched on a device.

For example:

<application ...> <activity android:name=".MainActivity" android:exported="true"> <intent-filter> <action android:name="android.intent.action.MAIN" /> <category android:name="android.intent.category.LAUNCHER" /> </intent-filter> </activity> </application>

gemini-code-assist · 2026-01-08T07:12:55Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                        .setSubscriptionUpdateParams(
+                                SubscriptionUpdateParams.newBuilder()
+                                        // purchaseToken can be found in Purchase#getPurchaseToken
+                                        .setOldPurchaseToken("old_purchase_token")


Hardcoding sensitive information like a purchase token is a critical security risk. Even if this is a placeholder for a sample, it promotes a dangerous practice. This value must be retrieved dynamically from the Purchase object of an existing subscription that the user owns.

gemini-code-assist · 2026-01-08T07:12:55Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+            // You could initiate a query here or show an error message.
+            return;
+        }
+        String purchaseTokenOfExistingSubscription = "purchase_token";


Hardcoding sensitive information like a purchase token is a critical security risk. Even if this is a placeholder for a sample, it promotes a dangerous practice. This value must be retrieved dynamically from the Purchase object of an existing subscription that the user owns.

gemini-code-assist · 2026-01-08T07:12:55Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                };
+
+        this.billingClient =
+                BillingClient.newBuilder(context)


To prevent potential memory leaks, the BillingClient should be initialized with the application context, not an activity context. The documentation for BillingClient.newBuilder() specifies that the application context should be used.

Suggested change

BillingClient.newBuilder(context)

BillingClient.newBuilder(context.getApplicationContext())

gemini-code-assist · 2026-01-08T07:12:55Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+    public BillingClientWrapper(Context context, Activity activity) {
+        this.context = context;
+        this.activity = activity;


Storing a direct reference to an Activity in a class that might have a longer lifecycle can lead to memory leaks. If this wrapper is meant to be a singleton or live longer than the activity, consider using a WeakReference<Activity> or ensuring its lifecycle is strictly bound to the activity's.

gemini-code-assist · 2026-01-08T07:12:55Z

gradle/libs.versions.toml

 androidxHiltNavigationCompose = "1.3.0"
 appcompat = "1.7.1"
 arcorePlayServices = "1.0.0-alpha09"
+playbilling = "8.3.0"


For better organization and to avoid potential conflicts, it's a good practice to name version aliases with a prefix related to the library group, for example, android-playbilling or google-playbilling.

Suggested change

playbilling = "8.3.0"

google-playbilling = "8.3.0"

gemini-code-assist · 2026-01-08T07:12:56Z

playbilling/src/main/java/com/example/pbl/BillingClientWrapper.java

+                        .setProductList(
+                                ImmutableList.of(
+                                        QueryProductDetailsParams.Product.newBuilder()
+                                                .setProductId("product_id_example")


Hardcoding product IDs like "product_id_example" makes the code less flexible and harder to maintain, especially if you have multiple products or different product IDs for different build variants (e.g., debug vs. release). It's better to pass these values as parameters or retrieve them from a configuration.

gemini-code-assist · 2026-01-08T07:12:56Z

playbilling/build.gradle

+    }
+
+    defaultConfig {
+        applicationId "com.example.pbl"


Using the com.example namespace is discouraged for production applications as it's reserved for documentation and samples. This can lead to conflicts when uploading to the Play Store. Please use a unique application ID, typically based on a reverse domain name you own.

gemini-code-assist · 2026-01-08T07:12:56Z

playbilling/.gitignore

@@ -0,0 +1 @@
+/build


It's a common convention for text files to end with a newline character. This prevents issues with some tools and file concatenation. Please add a newline at the end of this file.

/build

gemini-code-assist · 2026-01-08T07:12:56Z

playbilling/src/test/java/com/example/pbl/ExampleUnitTest.java

+    public void addition_isCorrect() {
+        assertEquals(4, 2 + 2);
+    }
+}


It's a common convention for text files to end with a newline character. This prevents issues with some tools and file concatenation. Please add a newline at the end of this file.

Suggested change

}

}

kumann-dev and others added 6 commits January 5, 2026 15:36

add pbl snippets

9272c15

Apply Spotless

55f5c09

fixed formatting issues

c770cbb

Merge branch 'pblv2' of https://github.com/android/snippets into pblv2

413dda7

added guava dependency

e85cb14

renamed playbillinglibrary directory to playbilling

69aa3b0

kumann-dev requested review from kkuan2011 and yrezgui as code owners January 8, 2026 07:10

gemini-code-assist bot reviewed Jan 8, 2026

View reviewed changes

Merge branch 'main' into kumann-pblsamples

8a569c6

	BillingClient.newBuilder(context)
	BillingClient.newBuilder(context.getApplicationContext())

do-not-review-wip-kumann-pblsamples #764

Are you sure you want to change the base?

do-not-review-wip-kumann-pblsamples #764

Uh oh!

Conversation

kumann-dev commented Jan 8, 2026

Uh oh!

snippet-bot bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

snippet-bot bot commented Jan 8, 2026 •

edited

Loading