Skip to content

Replace org.junit.Assert.assertEquals with kotlin.test.assertEquals for consistency #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

ogapants
Copy link
Contributor

What I have done and why

In PR #420, the project transitioned from JUnit assertions to kotlin.test.assertEquals.
However, I found one class where org.junit.Assert.assertEquals was still being used.
This PR updates it to maintain consistency across tests.
All tests pass after the change.

Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the fix to keep this consistent!

@alexvanyo alexvanyo merged commit 689ef92 into android:main Apr 3, 2025
5 checks passed
@ogapants ogapants deleted the patch-1 branch April 4, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants