Enhance: Bind extension to product flavor for robust type safety #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors flavor configuration in NiaFlavor.kt. The previous implementation relied on runtime type checks for ApplicationExtension and ApplicationProductFlavor, whereas the updated code leverages generics to explicitly bind the extension (E) to the product flavor (F). This change eliminates unnecessary runtime checks and enhances compile-time type safety. Additionally, the introduction of @JvmName(“configureFlavorsImpl”) resolves JVM signature clashes, streamlining our DSL and improving overall code clarity.
… plugin This commit runs the Spotless plugin on `build-logic` to ensure that all code adheres to our style guidelines. As a follow-up to the recent flavor configuration refactor, this cleanup reinforces our commitment to a robust, readable, and maintainable codebase without altering functionality.
laynepenney
force-pushed
the
enhance/extension-flavor-type-safety
branch
from
bfc9160 to
fe677ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request includes two commits aimed at improving the codebase:
1. Enhance: Bind extension to product flavor for robust type safety
What Changed:
Refactored flavor configuration in NiaFlavor.kt by eliminating runtime type checks for
ApplicationExtensionandApplicationProductFlavor. The new implementation leverages generics to explicitly bind the extension (E) to the product flavor (F), ensuring that configuration is unambiguous and type-safe at compile time.Why:
This change removes unnecessary runtime checks and enhances compile-time safety.
2. Enhance: Enforce consistent formatting with Spotless plugin
What Changed:
Ran the Spotless plugin across the codebase to ensure that all code adheres to the established style guidelines. This commit is purely a formatting cleanup and does not affect functionality.
Why:
Consistent formatting improves code readability and maintainability, reinforcing the commitment to a clean and uniform codebase through the
build-logicGradle module.Testing and Verification (CD into
build-logicDirectory)Local Tests:
Verified changes by running tests on the
DemoDebugvariant using the command:../gradlew build.Formatting:
Applied code formatting using the command:
../gradlew --init-script ../gradle/init.gradle.kts spotlessApply.Additional Context
This pull request is designed to strengthen type safety and clarity in the flavor configuration while also ensuring consistent code formatting throughout the
build-logicGradle module. Together, these changes contribute to a more robust and maintainable codebase.