Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clean-up] Add clean-up for SearchViewModel. #1818

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Clean-up] Add clean-up for SearchViewModel. #1818

wants to merge 1 commit into from

Conversation

iamjosephmj
Copy link

@iamjosephmj iamjosephmj commented Jan 26, 2025 •
edited
Loading

What I have done and why

Remove private val modifier from searchContentsRepository variable inside SearchViewModel

@Jaehwa-Noh
Copy link
Contributor

Why are you removing private val?
Anything needs to be access `searchContentsRepository ?

@iamjosephmj
Copy link
Author

iamjosephmj commented Feb 6, 2025 •
edited
Loading

Why are you removing private val? Anything needs to be access `searchContentsRepository ?

@Jaehwa-Noh Thankyou for looking into the PR. On the day I raised the PR, searchContentsRepository was only consumed by searchResultUiState.

Screenshot 2025-02-06 133920

Because of that reason, the studio was showing a lint warning as well

Screenshot 2025-02-06 134141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamjosephmj @Jaehwa-Noh