Resolve layout issues caused by edgeToEdge and keyboard overlap

[henni99]

Resolve #1025

[gemini-code-assist]

Hello @henni99, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #1025, which involves layout problems caused by edge-to-edge display and keyboard overlap. The solution involves adding safeDrawingPadding() to the TodoNavGraph composable to ensure content isn't obscured by system UI elements.

Highlights

• Layout Fix: Implements safeDrawingPadding() to TodoNavGraph to resolve layout issues related to edge-to-edge display and keyboard overlap.
• Dependency Update: Adds safeDrawingPadding import from androidx.compose.foundation.layout.

Changelog

• app/src/main/java/com/example/android/architecture/blueprints/todoapp/TodoActivity.kt
  • Imported safeDrawingPadding from androidx.compose.foundation.layout (line 23).
  • Modified setContent block to apply safeDrawingPadding() to the TodoNavGraph composable (line 39).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A screen's edge, a keyboard's rise,
Layouts break before our eyes.
Padding safe, a gentle art,
To keep the content set apart.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses layout issues caused by edge-to-edge and keyboard overlap by adding safeDrawingPadding to the TodoNavGraph. This is a good approach to ensure that the UI elements are not obscured by system UI elements. The changes are small and focused, making them easy to review.

Summary of Findings

• Safe drawing padding: The safeDrawingPadding modifier is used to avoid UI elements overlapping with system UI elements like the status bar and navigation bar. This is a good practice to ensure a consistent and user-friendly experience.

Merge Readiness

The pull request appears to be ready for merging. The changes are straightforward and address the reported issue. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

[thewyp]

这是来自QQ邮箱的假期自动回复邮件。   您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。