Jbuilder #64
Open
Jbuilder #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead isolate the completion functionality into 1 module and then select it base on available libraries
And a little makefile helper
Owner
|
Thanks. Regarding the toplevel - that is the actual iocaml-kernel so it will definitely be needed. It looks like jbuilder is about to get a bytecode only target ocaml/dune#104 along with which we'll probably need something along the lines of the expunge rule noted in the utop link in that issue. |
|
Is there something I can do to help push this PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, the first step in the master plan :P
One thing I'm not sure about is what to do about the custom top level. Jbuilder
hasn't gained the ability to create those yet but it seems like it's not
essential to go ahead with this port.