Skip to content

Revert "Fix log big size (#62)" #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Revert "Fix log big size (#62)" #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8afa648
Revert "Fix log big size (#62)"
andrewiggins Feb 12, 2023
d3357b0
Add changelog
andrewiggins Feb 12, 2023
e92f10a
Update pkg-lock
andrewiggins Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/spicy-cheetahs-work.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"v8-deopt-viewer": patch
"v8-deopt-webapp": patch
---

Revert "Fix log big size (#62)" #64
207 changes: 12 additions & 195 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/v8-deopt-viewer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
},
"dependencies": {
"httpie": "^1.1.2",
"msgpackr": "^1.8.1",
"open": "^8.4.0",
"sade": "^1.8.1",
"v8-deopt-generate-log": "^0.2.3",
Expand Down
12 changes: 3 additions & 9 deletions packages/v8-deopt-viewer/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
mkdir,
} from "fs/promises";
import { createReadStream } from "fs";
import { Packr } from "msgpackr";
import { fileURLToPath, pathToFileURL } from "url";
import open from "open";
import { get } from "httpie/dist/httpie.mjs";
Expand Down Expand Up @@ -139,14 +138,9 @@ export default async function run(srcFile, options) {
files: await addSources(groupDeoptInfo.files),
};

const deoptInfoString = new Packr({ variableMapSize: true }).encode(
deoptInfo
);
await writeFile(
path.join(options.out, "v8-data.bin"),
deoptInfoString,
"utf8"
);
const deoptInfoString = JSON.stringify(deoptInfo, null, 2);
const jsContents = `window.V8Data = ${deoptInfoString};`;
await writeFile(path.join(options.out, "v8-data.js"), jsContents, "utf8");

console.log("Generating webapp...");
const template = await readFile(templatePath, "utf8");
Expand Down
13 changes: 5 additions & 8 deletions packages/v8-deopt-viewer/src/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,13 @@
</head>
<body>
<div id="root"></div>
<script src="v8-data.js" type="text/javascript"></script>
<script src="v8-deopt-webapp.js" type="text/javascript"></script>
<script type="text/javascript">
fetch("/v8-data.bin")
.then((response) => response.arrayBuffer())
.then((buffer) =>
V8DeoptViewer.renderIntoDom(
new Uint8Array(buffer),
document.getElementById("root")
)
);
V8DeoptViewer.renderIntoDom(
window.V8Data,
document.getElementById("root")
);
</script>
</body>
</html>
Loading