Skip to content

Replace tape with node:test #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace tape with node:test #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
404852a
Convert generate-log to node:test
andrewiggins Dec 2, 2022
9aed229
Convert v8-deopt-viewer tests to node:test
andrewiggins Dec 2, 2022
f959403
Convert v8-deopt-parser to node:test and remove tape
andrewiggins Dec 2, 2022
7da3f8c
Drop node14 from testing matrix
andrewiggins Dec 2, 2022
33b18dd
Update CONTRIBUTING
andrewiggins Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node: [14, 16, 18]
node: [16, 18]

steps:
- uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ This project is a monorepo. Check each sub-repo's `Readme.md` for details about
Quick thoughts:

- `v8-deopt-parser` package should work in the browser and nodeJS and should correctly parse Linux, Windows, file: protocol, and http(s): protocol paths
- `v8-deopt-parser` uses `tape` for testing because it easily works with NodeJS ES Modules and runs easily runs natively in the browser (?does it?)

## Releasing

Expand Down
Loading