Migrate to Rust 2021, do a clippy pass and update dependencies #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Net negative, nice! ^^ |
domenicquirl
commented
Apr 22, 2022
rtzoeller
reviewed
May 5, 2022
Co-authored-by: Ryan Zoeller <[email protected]>
Author
|
@rtzoeller done. Probably not gonna be much of a difference for us because of other uses of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! So I'm doing a dependency pass on some code at the moment and I noticed an ancient version of
regex(together with some more recent versions) being compiled in. Looking at this in detail showed theregexdependency comes through the 4 year old version ofhandlebarsused in the build script here. While #18 notes something similar, they were satisfied with it not being a runtime dependency, while I am trying to get rid of the additional compile time.Hence, I have updated the
handlebarsdependency (and also minorly bumpednix) and in the process silenced some clippy lints and migrated to the 2021 edition (there wasn't really anything to do here, besides specifying the edition inCargo.toml).Do you think we could get a release with the updated dependency tree?