Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify mappend to avoid discarding #4

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

chris-martin
Copy link
Collaborator

@chris-martin chris-martin commented Feb 7, 2023

Closes #2

Copy link
Owner

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Actually, would be good to add a test case for the new behavior.

@chris-martin
Copy link
Collaborator Author

Test case will be good, but I was hoping to do that in a separate step after first perhaps doing some cleanup in the existing test suite.

Copy link
Owner

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine, thanks!

@andreasabel andreasabel merged commit 9067a6f into andreasabel:master Feb 8, 2023
@andreasabel andreasabel added this to the 0.5 milestone Feb 8, 2023
@andreasabel
Copy link
Owner

@chris-martin : I noticed this is still unreleased. I would be easier to release this with a test case in place. Would you contribute a test case?

@chris-martin
Copy link
Collaborator Author

Sure, added to my to-do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Semigroup instance
2 participants