Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Semigroup instance #2

Closed
andreasabel opened this issue Jul 26, 2022 · 3 comments · Fixed by #4
Closed

Improve Semigroup instance #2

andreasabel opened this issue Jul 26, 2022 · 3 comments · Fixed by #4
Milestone

Comments

@andreasabel
Copy link
Owner

@chris-martin has done unmerged work on the Semigroup instance, see

@chris-martin : Do you want to port your PR to this repo? Do you want to co-maintain ini?

@andreasabel andreasabel added this to the 0.5 milestone Jul 26, 2022
@andreasabel
Copy link
Owner Author

Ping @chris-martin.

@chris-martin
Copy link
Collaborator

Hi! Yes sorry I forgot all about this. Will resubmit the PR. I do still use the ini library and so I would be happy to help co-maintain.

@andreasabel
Copy link
Owner Author

@chris-martin Thanks for helping out with maintenance!
I invited you to this repo and added you on Hackage: https://hackage.haskell.org/package/ini/maintainers/

When you make releases, please stick to the current changelog format:

ini/CHANGELOG.md

Lines 1 to 8 in 092dd89

## 0.4.2
_2022-07-26, Andreas Abel_
- Fail parsing if the input is not completely consumed [#30](https://github.com/chrisdone/ini/pull/30)
- Print global values as well [#28](https://github.com/chrisdone/ini/pull/28)
Tested with GHC 7.0 - 9.4.1 RC1.

By this I mean that the changelog entry should contain, besides more substantial information,

  • date and name of maintainer who made the release
  • links to the issues addressed (or links to PRs that do not have an issue)
  • range of GHC versions supported by this release.

It is a bit unfortunate that the previous maintainer @chrisdone archived his repo instead of transferring it, so we do not have continuity in issue numbers.

This repo should be unforked at some point, but it could also be moved from my private account to a suitable organization.

andreasabel pushed a commit that referenced this issue Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants