Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements #21

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Update requirements #21

merged 1 commit into from
Jan 10, 2025

Conversation

suutari-ai
Copy link
Member

@suutari-ai suutari-ai commented Jan 10, 2025

Regenerate all requirements*.txt files to get the latest (compatible) package versions.

Also update the passari-workflow submodule so that its tests won't fail with the new pytest-asyncio version.

@suutari-ai
Copy link
Member Author

I wonder why this one test (TestMuseumPackageDownload.test_downloads_cached) seems to fail occasionally. It also failed on last PR and then rerun of the CI job fixed it.

This is the error in the log:

        # Every request should have been made once
        for url in REQUEST_URLS:
>           assert mock_museumplus.request_counters[url] == 1
E           assert 0 == 1

@suutari-ai
Copy link
Member Author

Hmm.. now it failed on passari-workflow's test_sync_attachments with the following output:

        if self._local._loop is None:
>           raise RuntimeError('There is no current event loop in thread %r.'
                               % threading.current_thread().name)
E           RuntimeError: There is no current event loop in thread 'MainThread'.

Regenerate all requirements*.txt files to get the latest (compatible)
package versions.

Also update the passari-workflow submodule so that its tests won't fail
with the new pytest-asyncio version.
@suutari-ai
Copy link
Member Author

Hmm.. now it failed on passari-workflow's test_sync_attachments with the following output:

OK, it seems that this fixed it: andersinno/passari-workflow#14.

That fix is now also part if this PR via a submodule update.

@suutari-ai suutari-ai merged commit 9300fa1 into main Jan 10, 2025
1 check passed
@suutari-ai suutari-ai deleted the update-reqs branch January 14, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants