Skip to content

feat: usage with gorhom bottom sheet #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Benelini
Copy link

@Benelini Benelini commented May 9, 2025

Added functionality so that this package can be used with gorhom/react-native-bottom-sheet. This mostly solves keyboard behaviour when the otp entry is used in the bottom sheet, otherwise its very tricky.

I also updated the types accordingly since RN 79 requires React 19 types.

@anday013
Copy link
Owner

@Benelini Hi, firstly thank you for your efforts. What about the people who're not using this lib with any bottom sheet? Is it right to bind everyone to have an extra dependency?

@akuul
Copy link
Contributor

akuul commented May 30, 2025

This is wrong. The package shouldn't depend on gorhom nor on RNGH

@anday013
Copy link
Owner

What you can do is to expose a prop for custom input rendering. Ex:

<OtpInput
...
customTextInput={GorhomTextInput}
...
/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants