Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Several clarifications from @gibson42

Co-authored-by: Richard Gibson <[email protected]>
  • Loading branch information
ben-allen and gibson042 authored Apr 2, 2024
1 parent 2829199 commit d51744b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions spec/datetimeformat.html
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ <h1>
1. Let _bestFormat_ be BasicFormatMatcher(_formatOptions_, _formats_).
1. Else,
1. Let _bestFormat_ be BestFitFormatMatcher(_formatOptions_, _formats_).
1. Set _dateTimeFormat_.[[DateTimeFormat]] to _bestFormat_.
1. Set _dateTimeFormat_.[[Patterns]] to _bestFormat_.
1. If _bestFormat_ has a field [[hour]], then
1. Set _dateTimeFormat_.[[HourCycle]] to _hc_.
1. Return _dateTimeFormat_.
Expand Down Expand Up @@ -258,7 +258,7 @@ <h1>Internal slots</h1>
[[LocaleData]].[[&lt;_locale_&gt;]].[[hourCycle24]] must be a String value equal to *"h23"* or *"h24"*.
</li>
<li>
[[LocaleData]].[[&lt;_locale_&gt;]] must have a [[formats]] field. This [[formats]] field must be a Record with [[&lt;_calendar_&gt;]] fields for all calendar values _calendar_. The value of this field must be a List of DateTime Format Records. Multiple Records in a List may use the same subset of the fields as long as they have different values for the fields. The following subsets must be available for each locale:
[[LocaleData]].[[&lt;_locale_&gt;]] must have a [[formats]] field. The value of this [[formats]] field must be a Record with a [[&lt;_calendar_&gt;]] field for each calendar value _calendar_. The value of each [[&lt;_calendar_&gt;]] field must be a List of DateTimeFormat Patterns Record. Multiple Records in such a List may use the same subset of the fields as long as the corresponding values differ for at least one field. The following subsets must be available for each locale:
<ul>
<li>weekday, year, month, day, hour, minute, second, fractionalSecondDigits</li>
<li>weekday, year, month, day, hour, minute, second</li>
Expand All @@ -275,18 +275,18 @@ <h1>Internal slots</h1>
</ul>
</li>
<li>
[[LocaleData]].[[&lt;_locale_&gt;]] must have a [[styles]] field. The [[styles]] field must be a Record with [[&lt;_calendar_&gt;]] fields for all calendar values _calendar_. The value of this field is a DateTime Calendar Style Record.
[[LocaleData]].[[&lt;_locale_&gt;]] must have a [[styles]] field. The value of this [[styles]] field must be a Record with a [[&lt;_calendar_&gt;]] field for each calendar value _calendar_. The value of each [[&lt;_calendar_&gt;]] field must be a DateTimeFormat Styles Record.
</li>
</ul>

<emu-clause id="sec-datetimeformat-format-record">
<h1>DateTime Format Records</h1>
<emu-clause id="sec-datetimeformat-patterns-record">
<h1>DateTimeFormat Patterns Records</h1>

<p>
Each <dfn id="datetimeformat-format-record" variants="DateTime Format Records">DateTime Format Record</dfn> has the fields defined in <emu-xref href="#table-datetimeformat-format-record"></emu-xref>.
Each <dfn id="datetimeformat-patterns-record" variants="DateTimeFormat Patterns Records">DateTimeFormat Patterns Record</dfn> has the fields defined in <emu-xref href="#table-datetimeformat-patterns-record"></emu-xref>.
</p>
<emu-table id="table-datetimeformat-format-record">
<emu-caption>DateTime Time Range Record</emu-caption>
<emu-table id="table-datetimeformat-patterns-record">
<emu-caption>DateTimeFormat Patterns Record</emu-caption>
<table class="real-table">
<thead>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion spec/locales-currencies-tz.html
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ <h1>
<emu-clause id="sec-pattern-string-types">
<h1>Pattern String Types</h1>
<p>
<dfn>Pattern String</dfn> is a String value which contains zero or more substrings of the form *"{name}"*. The syntax of the abstract pattern strings is an implementation detail and is not exposed to users of ECMA-402.
<dfn>Pattern String</dfn> is a String value which contains zero or more substrings of the form *"{key}"*, where key can be any nonempty sequence consisting only of elements from the ASCII word characters. The syntax of the abstract pattern strings is an implementation detail and is not exposed to users of ECMA-402.
</p>
</emu-clause>
</emu-clause>

0 comments on commit d51744b

Please sign in to comment.