Open
Conversation
| @@ -1,4 +0,0 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
I agree that config.json probably shouldn't be checked in, but maybe we can check in a file like config.sample.json w/ example parameters?
Member
|
this looks great @henryhund. Keen to hear thoughts form @jthandy and @cmerrick |
models/facebook_ads/model.sql
Outdated
| @@ -0,0 +1,35 @@ | |||
| create or replace view ac_hhund.facebook_ads_summary as ( | |||
Member
|
Two tiny comments otherwise I'm 👍 |
Author
|
@jthandy refactored this to set up ppc as a model, rather than analyses. per our convo yesterday. |
Member
|
This is a bit behind dbt at the moment; you really need to update these models to use current dbt conventions or it will cause builds from master to fail. Please LMK if you need help setting up dbt or with how to change your models in order to conform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.