Update sdk bindings #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dNechita
reviewed
Apr 30, 2024
include/tof_ros2cpp/aditof_utils.h
Outdated
| @@ -53,7 +53,7 @@ std::string * parseArgs(int argc, char ** argv); | |||
| std::shared_ptr<aditof::Camera> initCamera(std::string * arguments); | |||
| void startCamera(const std::shared_ptr<aditof::Camera> & camera); | |||
| void stopCamera(const std::shared_ptr<aditof::Camera> & camera); | |||
| void setFrameType(const std::shared_ptr<aditof::Camera> & camera, const std::string & type); | |||
| void setCameraMode(const std::shared_ptr<aditof::Camera> & camera, const std::string & type); | |||
There was a problem hiding this comment.
type->mode
Also, latest dev-5.1.0 uses int type for mode
dNechita
reviewed
Apr 30, 2024
src/aditof_utils.cpp
Outdated
| return; | ||
| } else { | ||
| LOG(INFO) << "Frame type set: " << type; | ||
| LOG(INFO) << "Frame mode set: " << mode; |
There was a problem hiding this comment.
It should be "Camera mode" not "Frame mode"
VHolonec
force-pushed
the
tofcmos-703-update-bindings
branch
2 times, most recently
from
c278a9c to
bd5cb7d
Compare
rbudai98
previously approved these changes
May 7, 2024
src/aditof_utils.cpp
Outdated
| void getAvailableFrameTypes( | ||
| const std::shared_ptr<aditof::Camera> & camera, std::vector<std::string> & availableFrameTypes) | ||
| void getAvailableModes( | ||
| const std::shared_ptr<aditof::Camera> & camera, std::vector<uint8_t> & availableModes) | ||
| { | ||
| //get available frae types of camera |
rbudai98
reviewed
May 7, 2024
src/tof_camera_node.cpp
Outdated
| @@ -246,17 +246,17 @@ int main(int argc, char * argv[]) | |||
| } | |||
|
|
|||
| // getting available frame types, backward compatibility | |||
rbudai98
dismissed
their stale review
Even though build works, the node does not start
|
2 more things need checking:
|
VHolonec
force-pushed
the
tofcmos-703-update-bindings
branch
from
bd5cb7d to
c68ebcb
Compare
|
Remove old config files from tof_config since they are no longer used. |
SeptimiuVana
reviewed
May 7, 2024
| @@ -53,13 +53,13 @@ std::string * parseArgs(int argc, char ** argv); | |||
| std::shared_ptr<aditof::Camera> initCamera(std::string * arguments); | |||
| void startCamera(const std::shared_ptr<aditof::Camera> & camera); | |||
| void stopCamera(const std::shared_ptr<aditof::Camera> & camera); | |||
| void setFrameType(const std::shared_ptr<aditof::Camera> & camera, const std::string & type); | |||
| void setCameraMode(const std::shared_ptr<aditof::Camera> & camera, const uint8_t & mode); | |||
There was a problem hiding this comment.
Do we need both setMode and setCameraMode?
There was a problem hiding this comment.
I removed setMode because is the same as setCameraMode
SeptimiuVana
reviewed
May 7, 2024
tof_config/logo.png
Outdated
VHolonec
force-pushed
the
tofcmos-703-update-bindings
branch
2 times, most recently
from
de78658 to
c61dc21
Compare
SeptimiuVana
reviewed
May 7, 2024
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "depthIni": "./config/RawToDepthAdsd3030_sr-native.ini;./config/RawToDepthAdsd3030_lr-native.ini;./config/RawToDepthAdsd3030_sr-qnative.ini;./config/RawToDepthAdsd3030_lr-qnative.ini;./config/RawToDepthAdsd3030_sr-mixed.ini;./config/RawToDepthAdsd3030_lr-mixed.ini;./config/RawToDepthAdsd_pcm-native.ini", | |||
| "depthIni": "./config/RawToDepthAdsd3030_0.ini;./config/RawToDepthAdsd3030_1;./config/RawToDepthAdsd3030_2.ini;./config/RawToDepthAdsd3030_3.ini;./config/RawToDepthAdsd3030_6.ini;./config/RawToDepthAdsd3030_5.ini;./config/RawToDepthAdsd_4.ini", | |||
There was a problem hiding this comment.
/config/RawToDepthAdsd3030_1 is missing .ini extension.
Signed-off-by: Vasile Holonec <[email protected]>
VHolonec
force-pushed
the
tofcmos-703-update-bindings
branch
from
c61dc21 to
06abc94
Compare
|
Do not merge this PR until branch dev-5.1.0 from tof is merged into main. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbudai98
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made for tof sdk from dev-5.1.0 branch.