Skip to content

adi: add support for AD-PQMON-SL #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adi: add support for AD-PQMON-SL #648

wants to merge 3 commits into from

Conversation

adisuciu
Copy link
Contributor

Signed-off-by: Adrian Suciu [email protected]# Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: AD-PQMON-SL
  • OS: Ubuntu 24.04

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@adisuciu adisuciu changed the title adi: add support for big endian rx buffers adi: add support for AD-PQMON-SL Mar 12, 2025
Copy link

github-actions bot commented Mar 12, 2025

Test Results

1 660 tests  ±0     426 ✅ ±0   11m 54s ⏱️ -1s
    1 suites ±0   1 232 💤 ±0 
    1 files   ±0       2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 819ec68. ± Comparison against base commit 8cc0bb6.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[10.0, 0.5, 14.5, 11.0, 23.5, 26.0, 8.5, 1.0, 13.5, 20.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[28.5, 5.0, 2.5, 27.0, 12.0, 0.0, 30.0, 12.5, 32.0, 29.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-13.2, -30.95, -16.3, -2.4, -1.7, -4.4, -32.85, -25.0, -29.9, -28.55]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-13.6, -33.65, -7.7, -32.1, -9.55, -28.0, -15.4, -36.95, -25.3, -2.15]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[6.5, 33.5, 7.5, 22.5, 19.5, 26.0, 1.0, 22.5, 22.5, 18.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[8.0, 10.5, 15.0, 23.0, 14.0, 16.0, 17.0, 26.0, 31.5, 0.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-35.45, -25.35, -22.9, -18.75, -18.5, -29.1, -28.9, -8.1, -17.1, -39.5]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-0.85, -20.0, -4.15, -25.95, -17.4, -11.05, -27.8, -8.5, -0.1, -25.15]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

♻️ This comment has been updated with latest results.

Copy link

Generated documentation for this PR is available at Link

@adisuciu adisuciu force-pushed the pqmon branch 4 times, most recently from c782968 to a5ea562 Compare March 17, 2025 12:47
Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need docstring on all public properties/methods. Also need context file for testing

Signed-off-by: Adrian Suciu <[email protected]>
@adisuciu
Copy link
Contributor Author

Added the docstrings and an emulator context.

@adisuciu adisuciu requested a review from tfcollins March 29, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants