-
Notifications
You must be signed in to change notification settings - Fork 118
adi: add support for AD-PQMON-SL #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results1 660 tests ±0 426 ✅ ±0 11m 54s ⏱️ -1s For more details on these failures, see this check. Results for commit 819ec68. ± Comparison against base commit 8cc0bb6. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Generated documentation for this PR is available at Link |
c782968
to
a5ea562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need docstring on all public properties/methods. Also need context file for testing
Signed-off-by: Adrian Suciu <[email protected]>
Signed-off-by: Adrian Suciu <[email protected]>
Signed-off-by: Adrian Suciu <[email protected]>
Added the docstrings and an emulator context. |
Signed-off-by: Adrian Suciu [email protected]# Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: