Add support for AD353xr #620
Merged
+447
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaikiranGudla
force-pushed
the
ad353xr_support
branch
from
a899f5c to
e2749d0
Compare
SaikiranGudla
force-pushed
the
ad353xr_support
branch
8 times, most recently
from
3c91481 to
337e85d
Compare
|
May I know if there are any comments on this PR, @tfcollins ? |
tfcollins
reviewed
Feb 17, 2025
adi/ad353xr.py
Outdated
| # SPDX short identifier: ADIBSD | ||
| # Copyright (C) 2025 Analog Devices, Inc. | ||
| # | ||
| # All rights reserved. |
There was a problem hiding this comment.
Large license not required if you have the SPDX short identifier
tfcollins
reviewed
Feb 17, 2025
adi/ad353xr.py
Outdated
| if not self._txdac: | ||
| raise Exception("Error in selecting matching device") | ||
|
|
||
| self.output_bits = [] |
There was a problem hiding this comment.
What is this property? If its expected to be used by end users then it needs to be documented. Otherwise it should not be "public"
There was a problem hiding this comment.
Yes, this gives the channel-wise number of output bits expected to be used by the end-user. Added the docstring as required!
SaikiranGudla
force-pushed
the
ad353xr_support
branch
from
337e85d to
27213a2
Compare
Resolved them! |
SaikiranGudla
force-pushed
the
ad353xr_support
branch
from
27213a2 to
af85c2a
Compare
Add ad353xr.py driver Add example code, test script Update index.rst, init.py, supported_parts.md files Add xml emu context file Update hardware_map.yml file for test emulation Signed-off-by: SGudla <[email protected]>
SaikiranGudla
force-pushed
the
ad353xr_support
branch
from
af85c2a to
f9ce56d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ad353xr.py driver
Add example script
Update index.rst, init.py, supported_parts.md files
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: