-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers:platform:freeRTOS:Added mem functions #2427
base: main
Are you sure you want to change the base?
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
Looks good to me As a side note, I think freertos.mk should contain something like, perhaps as a separate commit:
This would avoid having to specify these in the project .mk files. |
ae261cc
to
c390cfe
Compare
I was a bit hasty with my pull request. The last commit is compiling without error or warnings with STM32CubeIDE. |
* @param size - Size of the memory block, in bytes. | ||
* @return Pointer to the allocated memory, or NULL if the request fails. | ||
*/ | ||
__attribute__((weak)) void *no_os_malloc(size_t size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the weak linkage specified needed here ? i would argue that this file is THE implementation of no_os_alloc (.c/.h) for freertos platform so it should replace the 3 alloc API functions there (which are specified as weak) with non-weak versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, is the weak linkage what changed between your first and 2nd version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the weak linkage should be removed, and I have done that in my last commit now.
Add freeRTOS memory functions for no-OS implementation. Signed-off-by: Lars Andre Landås <[email protected]>
Add freeRTOS memory functions for no-OS implementation.
Pull Request Description
Added memory allocation functions for use in freeRTOS platform.
PR Type
PR Checklist