Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: power: adp1050: add support for adp1051 #2381

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

drivers: power: adp1050: add support for adp1051 #2381

wants to merge 4 commits into from

Conversation

ivangilmercano
Copy link

@ivangilmercano ivangilmercano commented Nov 29, 2024 •
edited
Loading

Pull Request Description

The ADP1051 is an advanced digital controller with a PMBusTM interface targeting high density, high efficiency dc-to-dc power
conversion. This controller implements voltage mode control with high speed, input line feedforward for enhanced transient and improved noise performance. Some of the added support to the adp1050 driver to support adp1051 include extra pwm output, light load mode, and deep light load mode.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kister-jimenez kister-jimenez self-requested a review November 29, 2024 06:57
@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kister-jimenez kister-jimenez marked this pull request as draft November 29, 2024 09:12
@ivangilmercano ivangilmercano force-pushed the dev/adp1051 branch 2 times, most recently from 41af4a3 to 4db75de Compare December 2, 2024 05:37
@buha
Copy link
Contributor

buha commented Dec 2, 2024

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

buha
buha requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@buha buha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to also update the project to the new project infrastructure.

Here's the PR with the changes with 3 modified projects as example: #2412

And here's a pending PR where I gave feedback with pretty much that needs to be changed, same applies to your PR.
#2411

@ivangilmercano ivangilmercano force-pushed the dev/adp1051 branch 2 times, most recently from 6e61a26 to ff4e668 Compare February 3, 2025 09:04
@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ivangilmercano ivangilmercano force-pushed the dev/adp1051 branch 2 times, most recently from 8babd7a to 3c565d7 Compare February 5, 2025 03:32
@ivangilmercano ivangilmercano marked this pull request as ready for review February 5, 2025 03:32
@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ivangilmercano ivangilmercano force-pushed the dev/adp1051 branch 2 times, most recently from cf209f2 to 1581577 Compare February 7, 2025 05:56
@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ivangilmercano ivangilmercano force-pushed the dev/adp1051 branch 2 times, most recently from 79376fc to b473b0e Compare February 7, 2025 07:27
@kister-jimenez
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiprianRegus CiprianRegus CiprianRegus left review comments

@jemfgeronimo jemfgeronimo jemfgeronimo left review comments

@buha buha buha requested changes

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

@kister-jimenez kister-jimenez Awaiting requested review from kister-jimenez

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivangilmercano @CLAassistant @kister-jimenez @buha @CiprianRegus @jemfgeronimo