Skip to content

Conversation

StancaPop
Copy link
Contributor

@StancaPop StancaPop commented Aug 1, 2025

PR Description

Add voltage levels & flags in ad_gmsl2eth_sl README files.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

IuliaCMoldovan
IuliaCMoldovan previously approved these changes Aug 13, 2025
@IuliaCMoldovan
Copy link
Contributor

Tagging @alin724 just to make sure

Copy link
Contributor

@alin724 alin724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VADJ notion won't be applicable here, as we don't have a FMC connector on this evaluation kit (is an evaluation kit made around K26 SoM [Zynq Ultrascale+ FPGA + ZynqMPSoC] but won't have FMC connectors that are connected to different IC's evaluation kits). We can mention the voltage level for the D-PHY-related I/Os that are then connected to the GMSL deserializer's pins, and for the I/O header's pins (a list-based element in the doc)

@IuliaCMoldovan
Copy link
Contributor

Should be merged before #1883

@alin724 alin724 self-requested a review August 20, 2025 14:36
@StancaPop StancaPop changed the title ad_gmsl2eth_sl: Add VADJ value in READMEs ad_gmsl2eth_sl: Add voltage levels in READMEs Aug 20, 2025
@StancaPop StancaPop merged commit 3e45a1d into main Aug 21, 2025
4 of 5 checks passed
@StancaPop StancaPop deleted the update_gmsl_readme branch August 21, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants