Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional generic pipeline stage in util_do_ram #1573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

podgori
Copy link
Contributor

@podgori podgori commented Feb 5, 2025

This commit makes the pipeline_stage module generic so that it can be imported by the util_do_ram to address timing issues in projects.
Two extra parameters are added in util_do_ram to control the pipeline length and the Read FIFO depth to ensure continuous data transmission.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

This commit makes the pipeline_stage module generic so that it can
be imported by the util_do_ram to address timing issues in projects.
Two extra parameters are added in util_do_ram to control the pipeline
length and the Read FIFO depth to ensure continuous data transmission.

Signed-off-by: Ionut Podgoreanu <[email protected]>
Comment on lines +265 to +276
.in({
rd_valid_l1,
rd_last_l1,
rd_data,
rd_keep
}),
.out({
rd_valid_s,
rd_last_s,
rd_data_s,
rd_keep_s
}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.in({
rd_valid_l1,
rd_last_l1,
rd_data,
rd_keep
}),
.out({
rd_valid_s,
rd_last_s,
rd_data_s,
rd_keep_s
}));
.in({
rd_valid_l1,
rd_last_l1,
rd_data,
rd_keep}),
.out({
rd_valid_s,
rd_last_s,
rd_data_s,
rd_keep_s}));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants