-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs/library/cn0363/* specific IPs #1550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review done using the GitHub GUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional review now using the proper tools...
Please do not commit trailing whitespace.
I sent patches privately to help applying the requested changes.
output.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page does not fully follow the template https://github.com/analogdevicesinc/hdl/blob/main/docs/library/template_ip/index.rst?plain=1 .
It is important to follow the template, one handy trick of the doc is to cycle the pages anchored on a particular section using Ctrl+Alt+Shift+Left/Right so we can "batch" check on particular section.
Actually, I forgot about this, you should replace here the links as well, to point to this new documentation and not the one from wiki: https://github.com/analogdevicesinc/hdl/blob/main/docs/projects/cn0363/index.rst?plain=1#L243-L246 |
Adds documentation for the CN0363 specific IPs: - CN0363 DMA Sequencer; - CN0363 Phase Data Sync. Signed-off-by: Carlos Souza <[email protected]> Signed-off-by: Jorge Marques <[email protected]>
PR Description
Adds documentation for the CN0363 specific IPs:
PR Type
PR Checklist