Improve typing so that TMCM3110 example types smoothly #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hoist __enter__/__exit__ from subclasses into `TmclInterface` - Add a few `if X is not None` - Add config for consistent import sorting
|
Thank you for your contributions. |
|
Aye, captain! |
|
But could you approve the workflow execution here? I would like to know if it works as intended. @trinamic-bp |
|
Your suggestion to trigger a Mypy check workflow on PR's is a great idea. However, we’d like to first think through which workflows to run and on which events, on our side. A separate PR is very much appreciated. |
|
Please review the files changed in this PR again. You've updated the description, but not the actual files modified by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist(Hoist __enter__/__exit__ into TmclInterface #128)__enter__/__exit__from subclasses intoTmclInterfaceif X is not NoneAdd job to detect if a pull request introduces typing problems(Add a new workflow to ensure that new contributions are correctly typed #129)Related to #125.