adi: Refactor AD4170 and add AD4190 support #48
Merged
+167
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansunil
force-pushed
the
refactor-ad4170-driver
branch
from
972bff1 to
e8c64e9
Compare
SaikiranGudla
requested changes
Feb 3, 2025
+adi/+AD4170/Base.m
Outdated
Comment on lines
85
to
88
| obj.setAttributeRAW('voltage0', 'fs', value, false, obj.iioDev); | ||
| obj.setAttributeRAW('voltage1', 'fs', value, false, obj.iioDev); | ||
| obj.setAttributeRAW('voltage2', 'fs', value, false, obj.iioDev); | ||
| obj.setAttributeRAW('voltage3', 'fs', value, false, obj.iioDev); |
There was a problem hiding this comment.
nit: Shall we implement in this way in a loop?
PrecisionToolbox/+adi/+AD7124/Base.m
Line 86 in 76240ce
Similar comment for setupInit() function
+adi/+AD4170/Rx.m
Outdated
| properties (Hidden, Constant) | ||
| ComplexData = false | ||
| channel_names = {'voltage0','voltage1','voltage2'... | ||
| 'voltage3','voltage4'}; |
There was a problem hiding this comment.
In the base class, we've setters till channel 3 only. Should we also add ch4 there?
There was a problem hiding this comment.
I'd limit it to channel3- as the default configurations in the FW are only till ch4
Restructured the AD4170 driver to use a base class Added support to AD4190 device Signed-off-by: Janani Sunil <[email protected]>
jansunil
force-pushed
the
refactor-ad4170-driver
branch
from
e8c64e9 to
20bd2d4
Compare
SaikiranGudla
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured the AD4170 driver to use a base class
Added support to AD4190 device
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist