-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce Nebula Metadata Proxy and Databuilder #1817
Conversation
3143ad1
to
ff1c42e
Compare
note: now the search is broken in the recent rebase: ff1c42e, maybe it's related to recently merged search change, will look into it later
|
4235894
to
d372829
Compare
is there a chance we could minimize this by reusing neo4j classes for some components? basically if neo4j speaks opencypher and nebula speaks it too can we reuse stuff like neo4j extractor, neo4j search data extractor, neo4j metadata proxy (but differently configured) etc? I understand how this might be difficult for write operations (but maybe not impossible) but read could surely reuse neo4j components? I like the idea of nebula as alternative to neo4j especially that it also speaks opencypher but I'd like to know how this can be achieved with reusing neo4j stuff as much as possible. do we need so much new code or can this be avoided? |
Thanks @mgorsk1 for your time to look into the proposal! Indeed, I also had seen yet another backend storage increases the burden introducing new features during the implementation of the reference PR for the proposal, and I just told myself to keep eye on all PRs after it's merged and lift it from my own efforts then. While, as you pointed, it doesn't scale at all, and it in big chance is a good opportunity to make cypher-based backend with some level of abstractions to share codes when possible. I will take this context and purpose in mind and see what could be done on the refactor. There are some challenges that nebula only support OpenCypher as a dialect and reusing query string itself isn't directly possible(see here), while the mindset to per each read functions are similar, thus, find a way to decouple cypher-speaking DB implementation from code to configurations looks possible(and worth it). Thanks. |
d372829
to
1e3de5d
Compare
Metadata: Nebula Proxy Databuilder: - Nebula Extractor - Nebula Search Data Extractor - Nebula CSV Loader - Nebula CSV Publisher - Nebula Serializer - Nebula Sample Data Loader Signed-off-by: wey-gu <[email protected]>
Signed-off-by: wey-gu <[email protected]>
Signed-off-by: wey-gu <[email protected]>
note: still need amundsen-io#1856 to be included to work as highlight_options introduced in frontend app but not yet merged in search service Signed-off-by: wey-gu <[email protected]>
Signed-off-by: wey-gu <[email protected]>
1e3de5d
to
f96e7f9
Compare
Closing as abandoned |
thanks @Golodhros , |
Metadata: Nebula Proxy
Databuilder:
Summary of Changes
see #1816
Tests
All New things were UT covered.
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.