-
Notifications
You must be signed in to change notification settings - Fork 47
fix(session replay): dynamically import plugin-console-record #983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably want to sync with you to better understand if there's any impact to how customers would install this and maybe how it'll fit into all the one line scripts we have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jxiwang LGTM
Summary
Break our
rrweb-console-plugin
import into a separate chunk.We are now dynamically importing our Session Replay Plugin in order to prevent the
rrweb-console-plugin
package from adding ~40KB to our size.Implications -
session-replay-browser
SDK is now an esm build.https://amplitude.atlassian.net/browse/SR-983?linkSource=email
https://amplitude.atlassian.net/wiki/spaces/IG/pages/3082682708/Session+Replay+SDK+Bundling
Checklist