feat(targeting): publish package so the page-url targeting fix ships#1845
Draft
bravecod wants to merge 2 commits into
Draft
feat(targeting): publish package so the page-url targeting fix ships#1845bravecod wants to merge 2 commits into
bravecod wants to merge 2 commits into
Conversation
@amplitude/targeting is marked private, so the release pipeline (lerna --no-private + pnpm publish) skips it entirely. The page-url targeting fix (#1571, on main since March) therefore never reached npm — every published targeting version (through 0.2.3) omits page from the eval context, so URL-based Session Replay targeting rules never match. This is the root cause of the 'TRC on but not recording' reports. - Remove private so targeting publishes through the normal release flow. - Bump 0.2.0 -> 0.2.3 to match the latest published version (repo was stale), so the next release bumps forward without a version collision. - Exclude the auto-generated version.ts from coverage (targeting doesn't import VERSION, so the lifecycle-generated file would fail the 100% threshold once targeting is versioned). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
size-limit report 📦
|
- @amplitude/element-selector@0.2.0-publish-sr-targeting.0 - @amplitude/plugin-session-replay-browser@1.32.2-publish-sr-targeting.0 - @amplitude/segment-session-replay-plugin@0.0.30-publish-sr-targeting.0 - @amplitude/session-replay-browser@1.46.1-publish-sr-targeting.0 - @amplitude/targeting@0.3.0-publish-sr-targeting.0 - @amplitude/unified@1.1.17-publish-sr-targeting.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@amplitude/targeting is marked private, so the release pipeline (lerna --no-private + pnpm publish) skips it entirely. The page-url targeting fix (#1571, on main since March) therefore never reached npm — every published targeting version (through 0.2.3) omits page from the eval context, so URL-based Session Replay targeting rules never match. This is the root cause of the 'TRC on but not recording' reports.
Summary
Checklist