chore(analytics-react-native): raise min iOS/tvOS to 13.0 (SDKRN-5) [2.2/5]#1824
chore(analytics-react-native): raise min iOS/tvOS to 13.0 (SDKRN-5) [2.2/5]#1824Mercy811 wants to merge 1 commit into
Conversation
Mercy811
changed the title
…o 13.0 Align the podspec with Amplitude-Swift (iOS 13.0 / tvOS 13.0), the floor of our native Swift SDK, so the RN and native SDKs advertise one support matrix. This also lets the upcoming SDKRN-5 connectivity module use NWPathMonitor (iOS/tvOS 12+) unguarded. Apps targeting iOS 10-12 fail pod install on upgrade. Xcode 15/16 can still target iOS 12, so this drops a technically-shippable target; deliberately shipped as a chore (no major version bump) with this note serving as the changelog callout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Mercy811
force-pushed
the
sdkrn-5-offline-2-2-ios-min13
branch
from
4efdea9 to
59a9c5f
Compare
size-limit report 📦
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59a9c5f80a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| s.platforms = { :ios => "10.0", :tvos => "10.0" } | ||
| # Mirrors Amplitude-Swift's deployment targets. | ||
| s.platforms = { :ios => "13.0", :tvos => "13.0" } |
There was a problem hiding this comment.
When this line ships, apps whose Podfile still targets iOS/tvOS 10–12 will stop being able to install this pod, so this is a breaking compatibility change. This repo’s lerna.json enables conventionalCommits, but the reviewed commit is chore(analytics-react-native): ... with no ! or BREAKING CHANGE footer; the Conventional Commits spec notes that types outside fix/feat have “no implicit effect in Semantic Versioning” unless they carry a breaking marker (https://www.conventionalcommits.org/en/v1.0.0/). Please mark the commit/release as breaking so users are not offered this deployment-target drop as a non-major/implicit update.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this is intentional, synced with the team. no one uses ios 10 and 11 and is safe to upgrade.
1 participant
Summary
Raises the
amplitude-react-nativepodspec minimum deployment target from iOS/tvOS 10.0 to 13.0, mirroring Amplitude-Swift (ios 13.0 / tvos 13.0).🤖 Generated with Claude Code