Skip to content

fix: Add missing dependency to @amplitude/analytics-connector #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

b-dur
Copy link

@b-dur b-dur commented Apr 17, 2025

Summary

This PR adds @amplitude/analytics-connector to the dependencies list in the package.json file.

Reason: this commit added the analytics-connector.ts file which imports from @amplitude/analytics-connector but the dependency isn't added to the dependencies list of the package.json.

Discovered: I was working on adding "Amplitude Session Replay" by following this doc. This failed running locally, since @amplitude/analytics-connector package was missing. The error lead me to the analytics-connector.ts file. I resolved this locally by installing the @amplitude/analytics-connector to my app.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@b-dur b-dur changed the base branch from v1.x to main April 17, 2025 09:00
@Mercy811 Mercy811 closed this Apr 17, 2025
@Mercy811 Mercy811 reopened this Apr 17, 2025
@Mercy811
Copy link
Contributor

Thanks @b-dur, I created a new pr #1031 to run CI tests. The workflow is not triggered when the merging branch is from a forked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants