Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Reset ActivityPlayer state and standardize icons using lucide-react #191

Merged
merged 5 commits into from
Feb 2, 2025
Merged

FIX: Reset ActivityPlayer state and standardize icons using lucide-react #191

merged 5 commits into from
Feb 2, 2025

Conversation

frederickbaier
Copy link
Contributor

Addresses two issues:

  1. Fixed a bug where ActivityPlayer state wasn't properly reset between sessions
  2. Replaced mixed icon libraries with consistent lucide-react alternatives for better maintenance

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

👋 Hi there!

🚀 Checkout Instructions

git fetch origin
git checkout refactor/bug-fixes

Happy coding! 🎉

@github-actions github-actions bot added the release: bug-fix Fixes addressing bugs and issues in the project. label Feb 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025

🚀 Expo preview is ready!

  • Project → cognikids
  • Platforms → android, ios
  • Scheme → cognikids
  • Runtime Version → exposdk:51.0.0
  • More info

Learn more about 𝝠 Expo Github Action

kuebrademirhan
kuebrademirhan approved these changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@kuebrademirhan kuebrademirhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code and reviewed the changes. It works without any problem, it is ready to be merged in the main branch.

@frederickbaier frederickbaier merged commit 3ac236d into main Feb 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuebrademirhan kuebrademirhan kuebrademirhan approved these changes

Assignees
No one assigned
Labels
release: bug-fix Fixes addressing bugs and issues in the project.
Projects
amos2024ws04-feature-board
Status: PR Archive
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederickbaier @kuebrademirhan