Fix page number #201
Merged
Fix page number #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kristikotini <[email protected]>
Signed-off-by: kristikotini <[email protected]>
Signed-off-by: kristikotini <[email protected]>
|
Understood regarding the .docx files. Will ignore the .docx in the acceptance criteria when reviewing. |
|
Working good and displaying page numbers for .pptx ready to merge |
yashbhesaniya
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.pptxdoc typesRelated Backlog Item
Issue: #188
Context
.pptxand.docxthe page number was not being added. This PR fixes the.pptxfiles but not.docxsince there is no straightforward and reliable way to find page numbers of these files.Checklist:
make formatto format my codeAdditional references