Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page-number): Add 1 to page_number #191

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(page-number): Add 1 to page_number #191

merged 1 commit into from
Jul 9, 2024

Conversation

kristikotini
Copy link
Contributor

Description

  • Add 1 to page number so it is more user friendly

Related Backlog Item

Issue: #182

Context

  • In metadata page number is indexed from 0 but for the user we want it in a more friendly way.

Checklist:

  • I have documented my changes
  • I have tested the changes and they work as expected
  • I have assigned this PR to someone
  • I have run make format to format my code

Additional references

@kristikotini kristikotini requested a review from iremozs July 9, 2024 19:43
@kristikotini kristikotini self-assigned this Jul 9, 2024
iremozs
iremozs approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@iremozs iremozs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@iremozs iremozs merged commit 16b8906 into develop Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iremozs iremozs iremozs approved these changes

Assignees

@kristikotini kristikotini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristikotini @iremozs