Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/split view #157

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Feat/split view #157

merged 7 commits into from
Jun 25, 2024

Conversation

iremozs
Copy link
Contributor

@iremozs iremozs commented Jun 23, 2024 •
edited
Loading

Description

  • Split view in graph visualization page, on the left side information about the generated graph is shown and there is a search bar and an answer box without any functionalities at the moment.
  • The graph name and the date graph is generated is sent to frontend for visualization

Related Backlog Item

Issue: #100

Context

  • To display important information about the generated graph

Checklist:

  • I have documented my changes
  • I have tested the changes and they work as expected
  • I have assigned this PR to someone
  • I have run make format to format my code

Additional references

@iremozs iremozs self-assigned this Jun 23, 2024
Sandeep-kumar-Ramesh
Sandeep-kumar-Ramesh reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Sandeep-kumar-Ramesh Sandeep-kumar-Ramesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, everything looks good. Would be nice if you use MUI components for better UX and code maintainance.

Sandeep-kumar-Ramesh
Sandeep-kumar-Ramesh reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Sandeep-kumar-Ramesh Sandeep-kumar-Ramesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, everything looks good. Would be nice if you use MUI components for better UX and code maintainance.

Project/frontend/src/components/Graph/index.css Outdated Show resolved Hide resolved
Project/frontend/src/components/Graph/index_visjs.tsx Outdated Show resolved Hide resolved
Project/frontend/src/components/Graph/index_visjs.tsx Outdated Show resolved Hide resolved
Project/frontend/src/components/Graph/index_visjs.tsx Outdated Show resolved Hide resolved
@Sandeep-kumar-Ramesh
Copy link
Contributor

Everything looks good!

Sandeep-kumar-Ramesh
Sandeep-kumar-Ramesh approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Sandeep-kumar-Ramesh Sandeep-kumar-Ramesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@iremozs
Merge branch 'develop' into feat/split-view
16bd135 
# Conflicts:
#	Project/backend/codebase/graph_creator/router.py
#	Project/backend/codebase/graph_creator/services/netx_graphdb.py
@iremozs iremozs merged commit 7a0b809 into develop Jun 25, 2024
1 check passed
@nikolas-rauscher nikolas-rauscher deleted the feat/split-view branch July 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandeep-kumar-Ramesh Sandeep-kumar-Ramesh Sandeep-kumar-Ramesh approved these changes

Assignees

@iremozs iremozs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iremozs @Sandeep-kumar-Ramesh