You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review From Sreeram (GitHub blocked, so could not add it here directly:
Reviewed & tested PR #158 (local-ai-use port discovery). Works as expected.
Tested on my laptop, with Lemonade 11.7.0 running on a non-default port (8040) - the setup the old code got wrong.
What I verified:
lemonade status --json → {"port":8040}; health check: 8040 → 200, 13305 → refused. So the old hardcoded-13305 code would have failed here.
The port regex correctly picks the service port 8040 and ignores the "WebSocket Port 9001" line in the same status output. .
End-to-end: Ran setup_local_ai.py with no --port → it auto-discovered 8040 and baked http://localhost:8040/ into all 11 endpoint URLs in AGENTS.md, zero references to 13305. Explicit --port override also works.
Image generation through the discovered 8040 endpoint also worked.
Suggested changes:
Documentation fix in reference.md : The remote-host section still says "firewall rules allow inbound 13305". Instead, wouldn't it be better to probably say "the port you chose."
resolve_port skips port discovery for any explicit --host, so pointing --host at your own machine via ::1/127.0.0.1 would fall back to 13305 instead of discovering. Unlikely in practice but worth considering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure lemonade discovery works regardless of the port being used