Optimize and create multiple SNP guests in the Ubuntu Host #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshmiSaiHarika
force-pushed
the
create-multiple-guests
branch
3 times, most recently
from
0476cc5 to
0a58ee3
Compare
LakshmiSaiHarika
changed the title
|
Hey @ryansavino and @DGonzalezVillal , I request for this PR review for the optimization of SNP guest creation process in the ubuntu host as per our previous meeting. Please let me know if any changes are required |
LakshmiSaiHarika
force-pushed
the
create-multiple-guests
branch
2 times, most recently
from
09b6f06 to
0801550
Compare
DGonzalezVillal
approved these changes
Dec 17, 2024
Comment on lines
+114
to
+117
| User created SNP guest via guest-name option can be stopped with the `--guest-name` option as follows: | ||
| ``` | ||
| ./snp.sh stop-guests --guest-name <user-guest-name> | ||
| ``` |
There was a problem hiding this comment.
I don't see this as part of the code, are you meaning to add it?
There was a problem hiding this comment.
In the documentation, I was just highlightling a way to stop guest for a specific guest.
--guest-name option sets the IMAGE env. variable for that specific guest, which stops the running IMAGE env variable as per the stop_guests() function.
Let me know if we don't want to show this in documentation?
There was a problem hiding this comment.
My bad, I misunderstood how that worked, you can ignore that.
There was a problem hiding this comment.
No worries, @DGonzalezVillal , thanks for approving this PR.
Hi @ryansavino , please let me know if any changes are required in this PR.
LakshmiSaiHarika
changed the title
Signed-off-by: Harika Nittala <[email protected]>
… a separate SNP guest This supports launch of various SNP Guests at the same time using unique guest name and guest qemu port. A separate SNP guest can be launched with the --guest-name and --guest-port command option as follows: ./snp.sh launch-guest --guest-name <user-guest-name> --guest-port <user-guest-port> Signed-off-by: Harika Nittala <[email protected]>
Updated to show the correct details for the guest SSH access. Signed-off-by: Harika Nittala <[email protected]>
…tion process Updated the ubuntu guest download process to download it once and re-use the same image to quickly create multiple guests with the improved performance. Update of the guest image download structure in ubuntu also helps to easily add support for the same in the other OS linux distros. Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
force-pushed
the
create-multiple-guests
branch
from
0801550 to
7edf7e1
Compare
DGonzalezVillal
approved these changes
Jan 21, 2025
LakshmiSaiHarika
added a commit
to LakshmiSaiHarika/sev-utils
that referenced
this pull request
Jan 24, 2025
This reads MSR 0xC0010010 SME, SNP bits to check if SME, SNP are set and enabled in the bios Bit amd#23 corresponds to the SME bit status Bit amd#24 corresponds to the SNP bit status Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
added a commit
to LakshmiSaiHarika/sev-utils
that referenced
this pull request
Jan 24, 2025
This verifies if SME, SNP are enabled in the host BIOS settings by reading SME and SNP bit status from MSR 0xC0010010 Bit amd#23 corresponds to the SME bit status Bit amd#24 corresponds to the SNP bit status Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
added a commit
to LakshmiSaiHarika/sev-utils
that referenced
this pull request
Jan 24, 2025
This verifies if SME, SNP are enabled in the host BIOS settings by reading SME and SNP bit status from MSR 0xC0010010 Bit amd#23 corresponds to the SME bit status Bit amd#24 corresponds to the SNP bit status Signed-off-by: Harika Nittala <[email protected]>
arvindskumar99
approved these changes
Jan 24, 2025
LakshmiSaiHarika
added a commit
to LakshmiSaiHarika/sev-utils
that referenced
this pull request
Jan 24, 2025
This verifies if SME, SNP are enabled in the host BIOS settings by reading SME and SNP bit status from MSR 0xC0010010 Bit amd#23 corresponds to the SME bit status Bit amd#24 corresponds to the SNP bit status Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
added a commit
to LakshmiSaiHarika/sev-utils
that referenced
this pull request
Jan 28, 2025
This verifies if SME, SNP are enabled in the host BIOS settings by reading SME and SNP bit status from MSR 0xC0010010 Bit amd#23 corresponds to the SME bit status Bit amd#24 corresponds to the SNP bit status Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can launch multiple SNP enabled guests at the same time using --guest-name option and export of HOST_SSH_PORT env. variables
Modified snp.sh to create a separate guest user directory and point the launch working directory to point the current specific guest user directory.
Enhanced the guest creation process via the download of base guest image from the URL once and re-use the same base guest image to create multiple SNP enabled guests.