Skip to content

List all conditions to support alert_condition update when paginated #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexpogue wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

List all conditions to support alert_condition update when paginated #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f27de61
Implement list_all for conditions
Dec 19, 2018
bf0d762
Use list_all in conditions update
Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion newrelic_api/alert_conditions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@ def list(self, policy_id, page=None):
params=self.build_param_string(filters)
)

def list_all(self, policy_id):
condition_list = []
cur_page_num = 1
next_page_definition = 'placeholder'
while next_page_definition is not None:
cur_page = self.list(policy_id, page=cur_page_num)
condition_list = condition_list + cur_page['conditions']

next_page_definition = cur_page.get('pages', {}).get('next', None)
cur_page_num = cur_page_num + 1

return {'conditions': condition_list}

def update(
self, alert_condition_id, policy_id,
type=None,
Expand Down Expand Up @@ -162,7 +175,7 @@ def update(
}

"""
conditions_dict = self.list(policy_id)
conditions_dict = self.list_all(policy_id)
target_condition = None
for condition in conditions_dict['conditions']:
if int(condition['id']) == alert_condition_id:
Expand Down