Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazyLoad: per slide #1338

Merged
merged 3 commits into from
Jun 28, 2015
Merged

lazyLoad: per slide #1338

merged 3 commits into from
Jun 28, 2015
+6 −1

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jun 28, 2015

This is a first shot at addressing #1337.

@alvarotrigo
Copy link
Owner

Thanks for it!
Just a couple of comments below.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 28, 2015

Thanks for your prompt response! I'm glad you like it and that the approach seems to be good.

I've pushed a "fixup!" comment.

Please let me know if it's good like that, and I'll squash it.

I've only quickly looked into this when I've realized that it needs to be optimized, and would have expected that my attempt wouldn't be that good probably.

@blueyed
Copy link
Contributor Author

blueyed commented Jun 28, 2015

What do you think about the idea from #1337 to pre-fetch the previous/next slide(s)?

This should be configurable as a number for the amount of surrounding items to pre-fetch, and default to 1 for next/prev, allowing for 0 to only load the current slide then.

Is this what lazyDistance was meant to be?
It could then apply to sections and slides maybe.

alvarotrigo added a commit that referenced this pull request Jun 28, 2015
@alvarotrigo
Merge pull request #1338 from blueyed/lazy-slides
33f8074 
lazyLoad: per slide
@alvarotrigo alvarotrigo merged commit 33f8074 into alvarotrigo:master Jun 28, 2015
@alvarotrigo
Copy link
Owner

Thanks for it, merged.

@blueyed blueyed mentioned this pull request Jun 29, 2015
Open
@blueyed
Copy link
Contributor Author

blueyed commented Jun 29, 2015

Thanks for merging it, although it was not really ready.

See #1340 for a follow-up regarding the lazyDistance idea.

@blueyed blueyed mentioned this pull request Jun 29, 2015
Closed
alvarotrigo added a commit that referenced this pull request Jul 10, 2015
@alvarotrigo
- Lazy load now also working for slide #1338
2aadea8 
- afterRender returns now the container element rather than `undefined` 
- New warning message when using `scrolLBar` and `scrollOverflow`. #1352
- Now timeouts are being cleared on destroy #1329
- Removed warning error when fullPage.js selector doesn't exist on the page #1284
- Updated documentation with a few clarifications #1306 #1354
- Improvement for Windows and IE 11 in touch devices #1245 #160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blueyed @alvarotrigo