Restructure Train by Voice composer into a 3-step accordion by shreeraman96 · Pull Request #661 · altic-dev/FluidVoice

shreeraman96 · 2026-07-20T06:16:50Z

Description

Fixes #648, where Train by Voice / Teach Pronunciation under Custom Dictionary showed no interactive prompts and left the Start button permanently inactive. This replaces the flat replacement composer with a guided 3-step accordion (① Word → ② Record → ③ Verify & Save) that always surfaces the next action, and hardens the underlying step state machine.

Changes:

Restructure the composer into a 3-step accordion with per-step status glyphs; extract pure step-derivation + readiness logic into a new SwiftUI-free, unit-tested DictionaryTrainingStepModel (DictionaryTrainingSnapshot groups the training state)
Reset the hasReachedVerify latch on every teardown path (Try Again, capture removal, mode toggle) so Verify never dead-ends with Save disabled
Reset lastAnnouncedTrainingStep on teardown and announce any forward step edge (incl. word → verify) for correct VoiceOver cues
Make Record/Verify headers non-interactive while the word is empty; surface save-failure errors in the Verify step
Move the trainingReplacement onChange onto the always-mounted accordion so programmatic word writes still reset progress
Add unit tests for step derivation, the readiness predicates, and edge cases (empty-word latch, case-insensitivity, pronunciation boundaries)

Type of Change

Related Issue or Discussion

Closes #648

Testing

Tested on Intel Mac
Tested on Apple Silicon Mac
Tested on macOS version: 26.5 (Tahoe)
Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources — 0 violations
Ran formatter locally: swiftformat --config .swiftformat — changed files pass
Ran tests locally: DictionaryTrainingStepModelTests — 20/20 passing

Screenshots / Video

Step 1 : Enter the word to teach

Step 2 : Record

Step 3 : Verify & save

Manual Add

Research preview

Before all shown at once

Notes

No shared-package (FluidIntelligence) changes — no cross-repo impact.
Findings from a two-model deep review + PR bot review (latch not reset on teardown, missing Verify-step error feedback, VoiceOver announcement gaps, empty-word dead-ends) are all fixed.

github-actions · 2026-07-20T06:17:03Z

The PR Policy check is blocking this PR because required template information is missing.

Please update the PR description with:

Screenshots / Video

Visual files detected:

Sources/Fluid/UI/CustomDictionaryView.swift
Sources/Fluid/UI/DictionaryTrainingStepModel.swift

Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template.

If this remains incomplete for 48 hours after opening, the PR may be closed.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 903a026ba3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-20T06:20:52Z

+    private var trainingVerifyStepBody: some View {
+        VStack(alignment: .leading, spacing: self.theme.metrics.spacing.sm) {
+            self.trainingFinalOutputPanel

            Button {
                Task { await self.addTrainedReplacement() }


Show verification errors in the Verify step

When advanced voice matching is enabled and addTrainedReplacement() fails to save the pronunciation profile, it sets trainingHasError and trainingStatusMessage while leaving the accordion on Verify. Because the footer that renders those errors is now only included in trainingRecordStepBody, this Verify body shows no failure feedback after the Add Replacement attempt fails, unlike the previous always-visible footer. Include the error/footer in this step as well so the user can see and recover from save failures.

Useful? React with 👍 / 👎.

greptile-apps · 2026-07-20T06:22:14Z

Greptile Summary

This PR fixes issue #648 by replacing the flat Train by Voice composer with a guided 3-step accordion (Word → Record → Verify & Save), and hardens the underlying step state machine so the Start button is no longer permanently inactive.

Extracts pure step-derivation logic into a new DictionaryTrainingStepModel (SwiftUI-free, fully unit-tested with 20 tests), backed by an immutable DictionaryTrainingSnapshot struct; CustomDictionaryView delegates all readiness and expansion computations to this model.
Resets both the hasReachedVerifyStep latch and the lastAnnouncedTrainingStep latch on every teardown path (Try Again, capture removal, mode toggle, word change), fixing the previously-flagged VoiceOver announcement gaps.
Adds the new DictionaryTrainingStepHeaderView component with per-step status glyphs, interactive headers that gate on word emptiness, a save-failure error surface in the Verify step, and a "recording locked" override for the expanded step.

Confidence Score: 4/5

Safe to merge for all sighted users; VoiceOver users may not hear the step-advance cue when manually navigating backward and then forward again without a teardown.

The core bug fix (Start button permanently inactive) and the accordion restructure are solid. Teardown paths all correctly reset both latches. The only remaining gap is in announceTrainingStepEdgeIfNeeded: lastAnnouncedTrainingStep is not updated during backward navigation, so a subsequent forward tap silently skips the step-③ announcement for VoiceOver users.

The announceTrainingStepEdgeIfNeeded function in CustomDictionaryView.swift (around line 2350) has the latch update gap on backward navigation.

_{Reviews (4): Last reviewed commit: "Apply swiftformat to CustomDictionaryVie..." | Re-trigger Greptile}

github-actions · 2026-07-20T06:27:38Z

FluidVoice PR build ready

Download FluidVoice-PR-661-a99cfbd10957

The artifact contains the ad-hoc-signed app ZIP, Xcode archive, build manifest, and installation instructions. It expires 5 days after the build.

Install the app

Extract the downloaded artifact, then extract FluidVoice-PR-661.app.zip.
Move FluidVoice Restructure Train by Voice composer into a 3-step accordion #661.app into the /Applications folder.

Open Terminal and remove the download quarantine marker:

xattr -dr com.apple.quarantine "/Applications/FluidVoice #661.app"

In Applications, Control-click FluidVoice Restructure Train by Voice composer into a 3-step accordion #661.app and choose Open.
If macOS still blocks it, open System Settings → Privacy & Security, click Open Anyway, and confirm.

This build has its own app identity, so its permissions are separate from the release version of FluidVoice.

View workflow run

Splits the flat replacement composer into Word -> Record -> Verify & Save steps with an extracted, unit-tested step-derivation model. - Extract pure step logic into DictionaryTrainingStepModel (SwiftUI-free) - Render composer as a 3-step accordion with per-step status glyphs - Reset hasReachedVerify latch on every teardown path (Try Again, capture removal, mode toggle) so Verify never dead-ends with Save disabled - Reset lastAnnouncedTrainingStep and announce any forward step edge (including word->verify) for correct VoiceOver cues - Make Record/Verify headers non-interactive while the word is empty - Move trainingReplacement onChange to the always-mounted accordion so programmatic word writes still reset progress - Add unit tests for step derivation, readiness predicates, and edges

- Reset lastAnnouncedTrainingStep on all teardown paths so the step-3 VoiceOver cue fires again on retry (resetTrainingVerificationAttempts, removeTrainingVariant) - Show save-failure errors in the Verify step body (footer previously lived only in the Record body) - Drop the unused trainingVariantsIsEmpty param from isOutputCovered - Introduce DictionaryTrainingSnapshot to collapse the step-model param packs (fixes function_parameter_count) and move accordion helpers into an extension (fixes type_body_length); no behavior change

github-actions Bot added needs PR template Pull request is missing required template content. needs screenshots Pull request needs screenshot or video evidence. labels Jul 20, 2026

chatgpt-codex-connector Bot reviewed Jul 20, 2026

View reviewed changes

greptile-apps Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread Sources/Fluid/UI/CustomDictionaryView.swift

Comment thread Sources/Fluid/UI/CustomDictionaryView.swift

Comment thread Sources/Fluid/UI/DictionaryTrainingStepModel.swift

github-actions Bot removed needs PR template Pull request is missing required template content. needs screenshots Pull request needs screenshot or video evidence. labels Jul 20, 2026

shreeraman arunachalam karikalan added 3 commits July 20, 2026 16:50

Apply swiftformat to CustomDictionaryView

a99cfbd

shreeraman96 force-pushed the fix/train-by-voice-accordion-648 branch from 6cac7d6 to a99cfbd Compare July 20, 2026 23:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Restructure Train by Voice composer into a 3-step accordion#661

Restructure Train by Voice composer into a 3-step accordion#661
shreeraman96 wants to merge 3 commits into
mainfrom
fix/train-by-voice-accordion-648

shreeraman96 commented Jul 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 20, 2026

Uh oh!

greptile-apps Bot commented Jul 20, 2026 •

edited

Loading

Confidence Score: 4/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

shreeraman96 commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Related Issue or Discussion

Testing

Screenshots / Video

Step 1 : Enter the word to teach

Step 2 : Record

Step 3 : Verify & save

Manual Add

Research preview

Before all shown at once

Notes

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

FluidVoice PR build ready

Install the app

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shreeraman96 commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading

greptile-apps Bot commented Jul 20, 2026 •

edited

Loading

github-actions Bot commented Jul 20, 2026 •

edited

Loading