content modelling/876 style pension view #9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will replace the edit action in the summary list
with the new designs, we are using the card on the view page.
so that it doesn't bleed over the edge of the full column width.
Harriethw
commented
Feb 5, 2025
| @@ -45,7 +45,7 @@ | |||
| <div class="govuk-grid-row"> | |||
| <div class="govuk-grid-column-full"> | |||
| <%= render( | |||
| ContentBlockManager::ContentBlock::Document::Show::SummaryListComponent.new( | |||
| ContentBlockManager::ContentBlock::Document::Show::SummaryCardComponent.new( | |||
There was a problem hiding this comment.
I'm not yet deleting the SummaryListComponent in Show because the SummaryCardComponent in Index inherits from it and there's a fair bit to unpick - think that makes sense to do when we go to re-design the Index view, but could pick it up here if we think we need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/oqYRwyZu/876-create-pension-block-w-o-rates
Some tweaks to the view screen of a Block
Follow these steps if you are doing a Rails upgrade.