WIP add search index method to landing page #9901
Draft
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because the Attachable module assumes that the class its attached to has a search_index method, which landing page doesn't. This usually comes from the Searchable module, but we don't need any of that behaviour. Actually we don't need Attachable either, I don't think - I think it's a hangover from when we were attaching CSVs to use for line graphs. But we're not doing line graphs now. We could remove it, but I'm slightly nervous about breaking something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I haven't worked out how to test this, or whether it's best to just nuke the Attachable include
This is needed because the Attachable module assumes that the class its attached to has a search_index method, which landing page doesn't. This usually comes from the Searchable module, but we don't need any of that behaviour.
Actually we don't need Attachable either, I don't think - I think it's a hangover from when we were attaching CSVs to use for line graphs. But we're not doing line graphs now. We could remove it, but I'm slightly nervous about breaking something.
Follow these steps if you are doing a Rails upgrade.