Upgrade app to rails 8 #9899
Merged
Upgrade app to rails 8 #9899
+264
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifatcha
force-pushed
the
rails-8-upgrade
branch
from
f3f9596 to
1b73c8d
Compare
We had a number of routes that were specified as resources but used non-resource methods in "only" or "except" configurations. This should never have been allowed and is no longer possible in Rails 8.
Nested Rails form inputs should be named in the format "level_1_name[level_2_name][level_3_name]", but we had a few examples where they were named in the format "level_1_name[level_2_name[level_3_name]]", which is incorrect. Up until Rails 8 that seemed to work anyway, but as of Rails 8 it no longer does.
These start failing after upgrading to Rails 8 due to an EOF error on the GET requests. I can't understand exactly why, but there is obviously some sort of pollution of shared state left over from the first POST request sent in the test. Controller tests shouldn't be testing multiple endpoints at once in any case, we have cucumber features for that.
ryanb-gds
force-pushed
the
rails-8-upgrade
branch
from
1b73c8d to
256e503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails no longer accepts incorrectly nested form input parameters.
https://trello.com/c/lYQQqSvP/3299-bump-apps-to-latest-version-of-rails-8
Follow these steps if you are doing a Rails upgrade.