Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content modelling/876 create pension block #9898

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Harriethw
Copy link
Contributor

@Harriethw Harriethw commented Feb 5, 2025

https://trello.com/c/oqYRwyZu/876-create-pension-block-w-o-rates

  • refactor create email feature specs
  • add Pension schema

Allowing the creation of Pension with no embedded rates or updates to the UI view (yet)


⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

we will shortly be adding a new schema type
- pension - which we will want separate feature specs
to test a new journey for schemas with embedded
objects within them.
here we add and test the ability to create a
new Pension object - this schema has embedded
`rate` objects within it, but we are not yet
enabling the creation of these objects, so for
now we just remove them.
@Harriethw Harriethw marked this pull request as ready for review February 5, 2025 11:52
@Harriethw Harriethw requested a review from pezholio February 5, 2025 11:53
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Harriethw Harriethw enabled auto-merge February 5, 2025 11:57
@Harriethw Harriethw merged commit df6ae0b into main Feb 5, 2025
20 checks passed
@Harriethw Harriethw deleted the content-modelling/876-create-pension-block branch February 5, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants